[libcxx-commits] [PATCH] D124555: [libcxx][AIX][z/OS] basic_ios<wchar_t> cannot store fill character WCHAR_MAX

[Chris Bowler via Phabricator via libcxx-commits]

cebowleratibm added inline comments.


================
Comment at: libcxx/include/ios:787
+#endif
         __fill_ = widen(' ');
     return __fill_;
----------------
SeanP wrote:
> Shouldn't __fill_set become true at this point?
Fair point.  I'll need to make `__fill_set_` mutable as well.

I don't think there's a functional problem because a non default fill will cause `__fill_set` to be set.  Here the problem is we'll redundantly `__fill_ = widen(' ')`, nonetheless the code is more clear if I implement it as you've suggested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124555/new/

https://reviews.llvm.org/D124555