[libcxx-commits] [PATCH] D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined

Mon May 2 18:07:36 PDT 2022

paulkirth added a comment.

so this is down to one failure: `support/test.support/test_macros_header.no_exceptions.verify.cpp` (https://buildkite.com/llvm-project/libcxx-ci/builds/10551#b46abad1-6a39-4118-8a86-b50e1aaab001).

The failing test expects an error due to exceptions being disabled, so I'm not sure we should expect that to pass in this config.

`_HAS_EXCEPTIONS = 0` disables exceptions by failing to provide definitions to exception classes, and is what gets set when `fno-exceptions` is used, but I don't think that compilation will fail with the expected message if you *only* set `_HAS_EXCEPTIONS = 0`, but don't also use `fno-exceptions`.

@phosek @mstorsjo @ldionne what's the course of action here? just maybe mark this as XFAIL? or disable this test if in this config?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103947/new/

https://reviews.llvm.org/D103947