[libcxx-commits] [PATCH] D124789: [libc++] Find a clang-format everybody is happy with

[Konstantin Varlamov via Phabricator via libcxx-commits]

var-const added a comment.

First two questions that come to my mind (we can move to Discord if you prefer):

1. What do we do about the numerous places in the existing codebase with "fancy" formatting? For example, the aligned typedefs inside `string`, or things like

  static_assert( foo<Bar>); // Notice the extra space
  static_assert(!foo<Baz>);

AFAIU, our only two alternatives are to either use `clang-format on/off` "pragmas" around those blocks, or just let go of the fancy formatting. I strongly doubt `clang-format` can be taught to emulate that (though would be happy to be wrong on this).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124789/new/

https://reviews.llvm.org/D124789