[libcxx-commits] [PATCH] D124695: [libc++] Avoid a Microsoft SAL macro.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D124695#3484759 <https://reviews.llvm.org/D124695#3484759>, @pkasting wrote:

> The MSAN failure doesn't look like me.

Correct that was main being broken. Please rebase your patch before the next iteration, that should fix these build errors.



================
Comment at: libcxx/include/__functional/perfect_forward.h:34
 private:
-    tuple<_Bound...> __bound_;
+  tuple<_Bound...> __bound__;
 
----------------
I'm not thrilled by the trailing double underscore, this deviates from our coding style.
Maybe change `__bound_` to `__bound_args_` in this file, please also update the template name to `_BoundArgs`.

Please make similar changes at other places, having function arguments with a trailing underscore will lead to confusion. If you're having trouble finding good names, leave a comment to the names you need assistance with.


================
Comment at: libcxx/test/libcxx/nasty_macros.compile.pass.cpp:81
 # define __allocator NASTY_MACRO
-# define __deallocate NASTY_MACRO
-# define __deref NASTY_MACRO
-# define __full NASTY_MACRO
-# define __in NASTY_MACRO
-# define __inout NASTY_MACRO
-# define __nz NASTY_MACRO
-# define __out NASTY_MACRO
-# define __part NASTY_MACRO
-# define __post NASTY_MACRO
-# define __pre NASTY_MACRO
+#  define __bound NASTY_MACRO
+#  define __deallocate NASTY_MACRO
----------------
Format errors aren't hard errors, so feel free to ignore them.
(At some point we should decide what we want with formatting.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124695/new/

https://reviews.llvm.org/D124695