[libcxx-commits] [PATCH] D123228: [libc++][WIP] Implement P0881R7 (std::stacktrace)

[Thorsten via Phabricator via libcxx-commits]

tschuett added inline comments.


================
Comment at: libcxx/src/stacktrace/stacktrace_entry.cpp:35
+
+namespace {
+string shorten_name(string str, string_view search, string_view replace) {
----------------
I do not know about the libcxx coding style, but LLVM prefers static over functions in anonymous namespaces. I believe there are quite a few functions that you could make static.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123228/new/

https://reviews.llvm.org/D123228