[libcxx-commits] [PATCH] D122738: [libc++] Use the Japanese locale.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 31 12:37:31 PDT 2022


Mordante planned changes to this revision.
Mordante added a comment.

The Linux CI changes are committed, but it will take some time before they are propagated to the build nodes.
I will look in a little while whether the propagation has been completed.



================
Comment at: libcxx/test/std/localization/locale.categories/category.time/locale.time.put.byname/put1.pass.cpp:87
+		std::cerr << ex << '\n'; // TODO REMOVE
+        assert(ex == "Today is 土曜日 which is the 6th day or alternatively 六.");
+    }
----------------
mstorsjo wrote:
> FWIW in other locale tests, we've used unicode escapes like `\u0123` instead of spelling them out as utf8 in the source.
Good point. I'll address that in the next revision.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122738/new/

https://reviews.llvm.org/D122738



More information about the libcxx-commits mailing list