[libcxx-commits] [PATCH] D122330: [libc++] Remove the __libcpp_version file

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 31 06:33:03 PDT 2022


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

In D122330#3418061 <https://reviews.llvm.org/D122330#3418061>, @rsmith wrote:

> There was an idea that we could use this to enable / disable version-specific workarounds for libc++/clang incompatibilities (eg, if recent clang sees it's using a sufficiently new version of libc++ then it can avoid enabling a workaround that's only necessary for older versions of libc++). We never implemented the clang side of this, though, so I don't think it's used by anything, and it seems like something we can add back later if there's a motivating use case.

Got it. Also, things have evolved to a point where libc++ and Clang are generally in rough lockstep with each other, so hopefully this shouldn't be necessary. I agree this can be added later if needed, but thanks for the additional context.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122330/new/

https://reviews.llvm.org/D122330



More information about the libcxx-commits mailing list