[libcxx-commits] [PATCH] D119933: [demangler] Add support for C++20 modules

Fangrui Song via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Mar 30 10:14:48 PDT 2022


MaskRay added inline comments.


================
Comment at: libcxxabi/src/demangle/ItaniumDemangle.h:1033
+  void printLeft(OutputBuffer &OB) const override {
+    Name->print(OB);
+    OB += '@';
----------------
`Name` can be nullptr here when the input is `"W2.c"` (would be parsed as a type). See my main comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119933/new/

https://reviews.llvm.org/D119933



More information about the libcxx-commits mailing list