[libcxx-commits] [PATCH] D122717: [libcxx] Stop recommending setting LIBCXX_HAS_WIN32_THREAD_API in the MinGW builds

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo created this revision.
mstorsjo added a reviewer: ldionne.
Herald added a subscriber: mgorny.
Herald added a project: All.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added a reviewer: libc++.

Since a8d15a926689c126c4d316788786e0160cfc1d5d <https://reviews.llvm.org/rGa8d15a926689c126c4d316788786e0160cfc1d5d> / D110975 <https://reviews.llvm.org/D110975>, this is
the default, even if winpthread headers are available, so we don't
need to cargo cult setting this option in all builds.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D122717

Files:
  libcxx/cmake/caches/MinGW.cmake
  libcxx/docs/BuildingLibcxx.rst


Index: libcxx/docs/BuildingLibcxx.rst
===================================================================
--- libcxx/docs/BuildingLibcxx.rst
+++ libcxx/docs/BuildingLibcxx.rst
@@ -156,7 +156,6 @@
   > cmake -G Ninja -S libcxx -B build                                                 \
           -DCMAKE_C_COMPILER=clang                                                    \
           -DCMAKE_CXX_COMPILER=clang++                                                \
-          -DLIBCXX_HAS_WIN32_THREAD_API=ON                                            \
           -DLIBCXX_CXX_ABI=libstdc++                                                  \
           -DLIBCXX_TARGET_INFO="libcxx.test.target_info.MingwLocalTI"
   > ninja -C build cxx
Index: libcxx/cmake/caches/MinGW.cmake
===================================================================
--- libcxx/cmake/caches/MinGW.cmake
+++ libcxx/cmake/caches/MinGW.cmake
@@ -1,5 +1,4 @@
 set(LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY OFF CACHE BOOL "")
-set(LIBCXX_HAS_WIN32_THREAD_API ON CACHE BOOL "")
 
 set(LIBCXX_CXX_ABI libcxxabi CACHE STRING "")
 set(LIBCXXABI_USE_LLVM_UNWINDER ON CACHE BOOL "")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122717.419094.patch
Type: text/x-patch
Size: 1141 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220330/5d29f817/attachment-0001.bin>