[libcxx-commits] [PATCH] D122532: Do not use non-POSIX strtoll_l and strtoull_l

Yuriy Chernyshov via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 29 14:31:39 PDT 2022


georgthegreat added a comment.

Thanks for pointing this out, @Mordante.
It turns out that our local version of musl/xlocale.h was lacking these two proxy functions for unknown reason.
Once I have restored them, the things got fixed.

While this fix allows to workaround the problem, I still see no reason for libcxx to provide `strtoull_l`.
It looks like it should be either provided by the underlying libc, or must not be used at all.

Current proxy from musl/xlocale.h does exactly the same this as I am proposing here, but does it libc-dependent way which only makes the logic more confusing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122532/new/

https://reviews.llvm.org/D122532



More information about the libcxx-commits mailing list