[libcxx-commits] [PATCH] D121435: [libc++] Canonicalize the ranges results and their tests

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 29 07:38:24 PDT 2022


ldionne accepted this revision.
ldionne added a comment.

LGTM with CI passing and with all the result types being disabled when `HAS_NO_INCOMPLTE_RANGES`. You'll also need to add `UNSUPPORTED: libcpp-has-no-incomplete-ranges` to some tests.



================
Comment at: libcxx/include/__algorithm/in_found_result.h:21
 
-#if _LIBCPP_STD_VER > 17 && !defined(_LIBCPP_HAS_NO_INCOMPLETE_RANGES)
 
----------------
Would it be possible to instead mark *all* the result types with `HAS_NO_INCOMPLETE_RANGES`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121435/new/

https://reviews.llvm.org/D121435



More information about the libcxx-commits mailing list