[libcxx-commits] [PATCH] D122530: [demangler] Support C23 _BitInt type

Mon Mar 28 08:01:05 PDT 2022

erichkeane added a comment.

In D122530#3411497 <https://reviews.llvm.org/D122530#3411497>, @zsrkmyn wrote:

> In D122530#3411466 <https://reviews.llvm.org/D122530#3411466>, @erichkeane wrote:
>
>> In D122530#3411449 <https://reviews.llvm.org/D122530#3411449>, @zsrkmyn wrote:
>>
>>> In D122530#3411232 <https://reviews.llvm.org/D122530#3411232>, @erichkeane wrote:
>>>
>>>> I wonder if there is value, for backwards compatibility to ALSO parse the old `_ExtInt` mangling?
>>>
>>> @erichkeane, I'm not sure what `_ExtInt` was mangled to in the past, but it now is also mangled as `DB`/`DU` using the latest clang, so it's enough to demangle `DB` and `DU` IMO.
>>
>> I went to look it up, we used to mangle it as a 'struct', so it demangled anyway (so `_ExtInt13` was : `U7_ExtIntILi13`, so `void foo(_ExtInt(13))` was `_Z3fooU7_ExtIntILi13EEi`.
>
> Thanks for explaination! So we don't need to make changes, right?

Correct, I don't believe so.  Sorry for the distraction/digression.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122530/new/

https://reviews.llvm.org/D122530