[libcxx-commits] [PATCH] D122530: [demangler] Support C23 _BitInt type

Mon Mar 28 04:48:52 PDT 2022

urnathan added a comment.

In D122530#3410157 <https://reviews.llvm.org/D122530#3410157>, @zsrkmyn wrote:

> In D122530#3410074 <https://reviews.llvm.org/D122530#3410074>, @aaron.ballman wrote:
>
>> Thank you for this! It looks correct to me, but the changes should probably come with some test coverage as well.
>
> There are actually some tests in libcxxabi/test/test_demangle.pass.cpp, but since the file is too large, phab folds it as a binary file :-(

yeah, that's getting problematic.  I wonder if we should break out all the testcases to a set of files in a subdir that the testprogram reads?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122530/new/

https://reviews.llvm.org/D122530