[libcxx-commits] [PATCH] D122072: [libc++][test] Adds an cpp20_output_iterator.

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Mar 27 16:16:42 PDT 2022


philnik accepted this revision as: philnik.
philnik added a comment.

LGTM



================
Comment at: libcxx/test/support/test_iterators.h:540-544
+    TEST_CONSTEXPR_CXX14 cpp20_output_iterator operator++(int) {
+        auto temp = *this;
+        ++*this;
+        return temp;
+    }
----------------
Mordante wrote:
> philnik wrote:
> > The post-increment `operator++` return `void` with the ranges stuff.
> Unfortunately that won't work since the concept requires ` *__it++ = _VSTD::forward<_Tp>(__t);`, deferring a `void` won't work.
That's not very intuitive, but OK.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122072/new/

https://reviews.llvm.org/D122072



More information about the libcxx-commits mailing list