[libcxx-commits] [PATCH] D121514: [libc++][format] Improve format-arg-store.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D121514#3410171 <https://reviews.llvm.org/D121514#3410171>, @vitaut wrote:

> You could do much better by having a single array and storing the type alternatives for the common case of small(ish) number of arguments in an integer. This is essentially what {fmt} does. I think the current implementation is based on Microsoft's which I'd strongly discourage.

I've developed this approach independently, but when I watched Charlie's CppCon talk I noticed the similarities between Microsoft's an my solution. Can you explain why you dislike this approach?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121514/new/

https://reviews.llvm.org/D121514