[libcxx-commits] [PATCH] D122479: [libcxx] Reuse TEXT macro from WIN32 for mapping strings to UNICODE

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

I think the reasoning/argument here is backwards. I wouldn't want to bring in the `TEXT()` macro here; what we do here is unrelated to the unicode switch for the Windows APIs.

So the issue is that the `PS()` macro we use right now can clash with some header on some OS? If that's the case, I don't mind changing it to a slightly longer macro, e.g. `PATHSTR()` or something like that, but please keep it untangled from the Win32 `TEXT()`/`UNICODE` macros.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122479/new/

https://reviews.llvm.org/D122479