[libcxx-commits] [PATCH] D122479: [libcxx] Reuse TEXT macro from WIN32 for mapping strings to UNICODE

Gustavo Henrique Nihei via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Mar 25 11:19:36 PDT 2022


gustavonihei created this revision.
Herald added a project: All.
gustavonihei updated this revision to Diff 418224.
gustavonihei added a comment.
gustavonihei updated this revision to Diff 418264.
gustavonihei edited the summary of this revision.
gustavonihei added reviewers: ldionne, philnik.
gustavonihei published this revision for review.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

[libcxx] Add UNICODE definition to be used by <windows.h>


gustavonihei added a comment.

[libcxx] Defined UNICODE to 1 to prevent macro redefinition warning


This patch also addresses a clash with the PS register from Xtensa
defined in the <specreg.h> header file, which is commonly included in
OS implementation.

Issue identified while building libc++ port for Apache NuttX, targetting
Xtensa-based chips (e.g. Espressif's ESP32 and ESP32-S3).

Signed-off-by: Gustavo Henrique Nihei <gustavo.nihei at espressif.com>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D122479

Files:
  libcxx/src/filesystem/filesystem_common.h
  libcxx/src/filesystem/operations.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122479.418264.patch
Type: text/x-patch
Size: 5326 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220325/206d527e/attachment.bin>


More information about the libcxx-commits mailing list