[libcxx-commits] [PATCH] D122351: [libc++] Remove the _LIBCPP_BOOL_CONSTANT macro

[Louis Dionne via Phabricator via libcxx-commits]

ldionne marked an inline comment as done.
ldionne added inline comments.


================
Comment at: libcxx/include/exception:303
 template <class _From, class _To>
-struct __can_dynamic_cast : public _LIBCPP_BOOL_CONSTANT(
+struct __can_dynamic_cast : _BoolConstant<
               is_polymorphic<_From>::value &&
----------------
mstorsjo wrote:
> This previously was `public _LIBCPP_BOOL_CONSTANT`, now it's a plain `_BoolConstant` - is the lost `public` keyword relevant here or not?
Not really, since it's a `struct` so it's public by default. The usual convention in metaprogramming is to omit the `public` and use `struct`s all the time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122351/new/

https://reviews.llvm.org/D122351