[libcxx-commits] [PATCH] D122395: [libc++] Audit all uses of _LIBCPP_ASSERT and _LIBCPP_DEBUG_ASSERT

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 24 08:46:06 PDT 2022


philnik accepted this revision as: philnik.
philnik added inline comments.


================
Comment at: libcxx/include/list:2044
         "list::splice(iterator, list, iterator, iterator) called with third iterator not referring to the list argument");
+    _LIBCPP_DEBUG_ASSERT(this != _VSTD::addressof(__c) || !std::__iterator_in_range(__f, __l, __p),
+        "list::splice(iterator, list, iterator, iterator)"
----------------
Since you are touching these lines anyways, could you replace the `_VSTD` uses?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122395/new/

https://reviews.llvm.org/D122395



More information about the libcxx-commits mailing list