[libcxx-commits] [PATCH] D110005: [WIP][CMake] Unify variable names

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 24 05:31:12 PDT 2022


mstorsjo updated this revision to Diff 417892.
mstorsjo added a comment.

Rebased to current git main. I split out the parts concerning `-std=c11` in compiler-rt, as those can be handled differently, separately from this.

I also split out rewriting of the variable name for the `-ffreestanding` flag in compiler-rt, as that test doesn't seem to be shared with any of the other runtimes.

So far, I think the scope of the patch was to rename all of the variable names within libcxx/libcxxabi/libunwind, and the ones in compiler-rt that overlaps any of them, but there's lots of more variables in compiler-rt that could be renamed consistently, even if it doesn't add any extra cache sharing across projects.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110005/new/

https://reviews.llvm.org/D110005

Files:
  compiler-rt/CMakeLists.txt
  compiler-rt/cmake/config-ix.cmake
  libcxx/CMakeLists.txt
  libcxx/cmake/Modules/HandleLibcxxFlags.cmake
  libcxx/cmake/config-ix.cmake
  libcxxabi/CMakeLists.txt
  libcxxabi/cmake/Modules/HandleLibcxxabiFlags.cmake
  libcxxabi/cmake/config-ix.cmake
  libcxxabi/src/CMakeLists.txt
  libunwind/CMakeLists.txt
  libunwind/cmake/Modules/HandleLibunwindFlags.cmake
  libunwind/cmake/config-ix.cmake
  libunwind/src/CMakeLists.txt
  runtimes/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110005.417892.patch
Type: text/x-patch
Size: 22961 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220324/d3f48066/attachment-0001.bin>


More information about the libcxx-commits mailing list