[libcxx-commits] [PATCH] D121530: [WIP][libc++][format] Implement format-string.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/test/std/utilities/format/format.functions/format.pass.cpp:51
+  // A basic ill-formed test is done in format.verify.cpp
+  // The exceptions are tested by other functions that don't use the basic-format-string as fmt argument.
 };
----------------
Is it not possible to call `std::format` with a non-constant format-string, in which case I would assume that we still get an exception? If so, we should test it too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121530/new/

https://reviews.llvm.org/D121530