[libcxx-commits] [PATCH] D121822: [bootstrap] Allow passing options to sub-builds for all targets

Mon Mar 21 18:17:25 PDT 2022

phosek added a comment.

This actually broke our build. We pass `LIBCXX_<option>` to the default build on Darwin and `RUNTIME_<target>_LIBCXX_<option>` to the per-target build, but with this change, the `LIBCXX_<option>` now affects the per-target builds as well which is undesirable.

We need a way to pass options to Darwin builds. D117263 <https://reviews.llvm.org/D117263> is an attempt at that but that change hasn't landed yet. Would it be fine with you if I reverted your change while we figure out a solution?

In D121822#3397391 <https://reviews.llvm.org/D121822#3397391>, @ldionne wrote:

> I'm going to land this. What kind of migration story do you want for the per-target properties (which should be handled as a separate effort)?

I'd like to use this opportunity to land D117263 <https://reviews.llvm.org/D117263> so you can do `LIBCXX_TEST_CONFIG_foo` and not necessarily just `LIBCXX_TEST_CONFIG_x86_64-linux-gnu`. I'll update that change to support the new scheme.

We then need to decide if we want to continue supporting the current scheme `RUNTIMES_<target>_<project>_<option>` scheme. If not, then we need to start emitting a warning and mention that we'll deprecate that scheme in the next release.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121822/new/

https://reviews.llvm.org/D121822