[libcxx-commits] [libcxx] 0f05200 - [libc++][AIX] AIX allows for changing permissions of symlinks

Zarko Todorovski via libcxx-commits libcxx-commits at lists.llvm.org
Mon Mar 21 11:39:41 PDT 2022


Author: Zarko Todorovski
Date: 2022-03-21T14:39:37-04:00
New Revision: 0f0520003af4e949d780996948d14c2d0b77a022

URL: https://github.com/llvm/llvm-project/commit/0f0520003af4e949d780996948d14c2d0b77a022
DIFF: https://github.com/llvm/llvm-project/commit/0f0520003af4e949d780996948d14c2d0b77a022.diff

LOG: [libc++][AIX] AIX allows for changing permissions of symlinks

The test fails on AIX due to it expecting an error as on Linux. However, as on
other non-Linux systems symlinks permissions are supported so expect an empty
error code.

Reviewed By: daltenty, #libc, ldionne

Differential Revision: https://reviews.llvm.org/D121140

Added: 
    

Modified: 
    libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.permissions/permissions.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.permissions/permissions.pass.cpp b/libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.permissions/permissions.pass.cpp
index 2d3afc2dd4d5d..7cf1c7208a619 100644
--- a/libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.permissions/permissions.pass.cpp
+++ b/libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.permissions/permissions.pass.cpp
@@ -8,8 +8,6 @@
 
 // UNSUPPORTED: c++03
 
-// XFAIL: LIBCXX-AIX-FIXME
-
 // <filesystem>
 
 // void permissions(const path& p, perms prms,
@@ -164,7 +162,7 @@ TEST_CASE(test_no_resolve_symlink_on_symlink)
         {perms::owner_all, perms::group_all, perm_options::remove},
     };
     for (auto const& TC : cases) {
-#if defined(__APPLE__) || defined(__FreeBSD__) || defined(__NetBSD__)
+#if defined(__APPLE__) || defined(__FreeBSD__) || defined(__NetBSD__) || defined(_AIX)
         // On OS X symlink permissions are supported. We should get an empty
         // error code and the expected permissions.
         const auto expected_link_perms = TC.expected;


        


More information about the libcxx-commits mailing list