[libcxx-commits] [PATCH] D120951: [libc++] Prepare string tests for constexpr

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Mar 19 10:45:40 PDT 2022


philnik added a comment.

In D120951#3394287 <https://reviews.llvm.org/D120951#3394287>, @Mordante wrote:

> LGTM! Just curious did you test locally whether these are really the final preparation changes required?
> Note I don't see that as blocking, the additional changes can be done when `std::string` is made `constexpr`.

I have a (almost) working `constexpr std::string` version locally and these should be the last diffs in the test files other than actually enabling the tests. I had to cherry-pick these changes manually, so I might have missed something.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120951/new/

https://reviews.llvm.org/D120951



More information about the libcxx-commits mailing list