[libcxx-commits] [PATCH] D107500: [libc++][ranges] Implement `lazy_split_view`.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Mar 19 10:17:27 PDT 2022


Mordante added a comment.

I just had a quick look over the latest changes, only noticed on issue.
As mentioned in D121204 <https://reviews.llvm.org/D121204> I'll leave the approval to somebody more familiar with ranges.



================
Comment at: libcxx/test/std/ranges/range.adaptors/range.lazy.split/general.pass.cpp:306
+    test_function_call("abc def", ' ', std::array{"abc", "def"});
+    // `wchar_t`.
+    test_function_call(L"abc def", L' ', std::array{L"abc", L"def"});
----------------
Since not all plaforms support `wchar_t` this needs to be guarded by `#ifndef TEST_HAS_NO_WIDE_CHARACTERS`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107500/new/

https://reviews.llvm.org/D107500



More information about the libcxx-commits mailing list