[libcxx-commits] [PATCH] D121216: [libc++] Enable modernize-loop-convert

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

I'm fine with this change for the sole reason that I find the diff after easier to read, too.

I'm fine with enabling the clang-tidy check as a "fly-by", however as @Quuxplusone said, if clang-tidy ever starts complaining about stuff and suggesting changes that we don't think are improvements, we'll want to disable those checks. In other words, I'm fine with this change since I think it *is* an improvement, but I want to make it clear that we're not blindly following what the tool tells us.

I agree with others that clang-tidy is probably missing a bunch of places where this can be applied, however we can tackle them as they come, and I guess I find it reassuring that clang-tidy is on the more conservative side.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121216/new/

https://reviews.llvm.org/D121216