[libcxx-commits] [PATCH] D121647: [runtimes] Detect changes to Tests.cmake

[Petr Hosek via Phabricator via libcxx-commits]

phosek added a comment.

In D121647#3386971 <https://reviews.llvm.org/D121647#3386971>, @ldionne wrote:

> In D121647#3386791 <https://reviews.llvm.org/D121647#3386791>, @phosek wrote:
>
>> @ldionne would you be willing to accept this? This should address the issue reported in D121276 <https://reviews.llvm.org/D121276>.
>
> I don't see something fundamentally wrong with it, but CI isn't passing on the Bootstrapping build, so it looks like something's off. Sorry, I was waiting for CI to be green before reviewing.

I think I understand the issue, I'll upload a new version soon.



================
Comment at: llvm/runtimes/CMakeLists.txt:225
+      # This file will be later replaced by the runtimes subbuild.
+      file(TOUCH ${LLVM_BINARY_DIR}/runtimes/Tests.cmake)
     endif()
----------------
ldionne wrote:
> I'm a bit confused -- doesn't this mean that we're going to include an empty `Tests.cmake` file and hence all the `LLVM_RUNTIMES_LIT_TESTSUITES` & friends below will expand to nothing?
Yes, this is just so we can include this file unconditionally below which is only necessary during the clean build. We could also use `include(... OPTIONAL)` but in my experience that didn't result in `Tests.cmake` being properly tracked by Ninja until you re-run CMake.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121647/new/

https://reviews.llvm.org/D121647