[libcxx-commits] [PATCH] D114896: [runtimes][CI] Add a 5 minutes individual test time out

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 17 14:15:16 PDT 2022


ldionne added a comment.
Herald added a project: All.

In D114896#3165444 <https://reviews.llvm.org/D114896#3165444>, @dblaikie wrote:

> Could this be put into the lit config itself, so it applies to even local/developer invocations rather than only CI invocations?

Sorry for dropping this on the floor -- I've actually been wondering about what's the best answer to this. I believe I've convinced myself that no, the timeout should really only be on the CI nodes. Indeed, the test suite could be run on e.g. a simulator device that is extremely slow, and we wouldn't, in that case, have such a timeout. So I think the correct thing to do is tie this timeout to our CI fleet only, where we know we must have reasonable timing guarantees.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114896/new/

https://reviews.llvm.org/D114896



More information about the libcxx-commits mailing list