[libcxx-commits] [PATCH] D121164: [libcxx] [ci] Check that Windows static libraries don't contain dllexports

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/test/libcxx/vendor/clangcl/static-lib-exports.sh.cpp:11-12
+
+// This file checks that the built static library doesn't contain dllexport
+// directives.
+
----------------
ldionne wrote:
> 
MinGW is also Windows, but maybe "in clang-cl builds"?


================
Comment at: libcxx/test/libcxx/vendor/clangcl/static-lib-exports.sh.cpp:14
+
+// RUN: llvm-readobj --coff-directives "%{lib}/libc++.lib" | not grep -i "export:" > /dev/null
+
----------------
ldionne wrote:
> Is `llvm-readobj` always available? If not, it would be nice to avoid the creation of a different `lit` feature for each utility that we need to use. I wonder whether it would be a reasonable requirement to make sure `llvm-readobj` is built in order to run the libc++ test suite. Maybe not?
Technically I guess it could be possible to not have it, but it's available in the CI environment and it's available in the LLVM installer on Windows, so I don't think we'd have anyone come complaining about running the libcxx tests and having this test failing due to the tool missing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121164/new/

https://reviews.llvm.org/D121164