[libcxx-commits] [PATCH] D121265: [libc++] [test] Add ranges_robust_against_copying_*.pass.cpp

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Mar 16 13:47:04 PDT 2022


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM with comments



================
Comment at: libcxx/test/libcxx/algorithms/ranges_robust_against_copying_comparators.pass.cpp:8
+//===----------------------------------------------------------------------===//
+
+// UNSUPPORTED: c++03, c++11, c++14, c++17
----------------
Both added tests could use a short comment explaining what they're testing. It's not difficult to figure out by reading the code, but it's always nice to have a comment in prose explaining exactly what this does -- it helps save time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121265/new/

https://reviews.llvm.org/D121265



More information about the libcxx-commits mailing list