[libcxx-commits] [PATCH] D121515: [libc++][NFC] Add TEST_HAS_NO_INCOMPLETE_RANGES.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 15 19:14:43 PDT 2022


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

In D121515#3377388 <https://reviews.llvm.org/D121515#3377388>, @philnik wrote:

> You said it yourself: The macro will be removed. We don't run any CI with `_LIBCPP_HAS_NO_INCOMPLETE_RANGES`, do we? If not I see no reason not do disable the entire test. It will only be disabled for those who don't ship ranges currently. I guess we should ask @ldionne what he thinks.

We do run CI with `HAS_NO_INCOMPLETE_RANGES` in the `no-experimental` CI job. Furthermore, that configuration is actually the default that we ship -- in other words, as far as users are concerned, they only see the library with `HAS_NO_INCOMPLETE_RANGES`, so it's important to test it if we can (until we can get rid of it entirely).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121515/new/

https://reviews.llvm.org/D121515



More information about the libcxx-commits mailing list