[libcxx-commits] [PATCH] D120180: [libc++][ranges] Implement changes to reverse_iterator from One Ranges Proposal.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

Thanks! LGTM with rewording suggestion for diagnostic.



================
Comment at: libcxx/include/__iterator/reverse_iterator.h:52
+    static_assert(__is_cpp17_bidirectional_iterator<_Iter>::value || bidirectional_iterator<_Iter>,
+        "The Iterator template argument must be a bidirectional iterator.");
+#endif // _LIBCPP_STD_VER > 17
----------------
I'd prefer something like `reverse_iterator<It> requires It to be a bidirectional iterator`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120180/new/

https://reviews.llvm.org/D120180