[libcxx-commits] [PATCH] D120684: [libc++] Define _LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER whenever we enable warnings in the test suite

Tue Mar 15 14:17:05 PDT 2022

ldionne added a comment.

In D120684#3383749 <https://reviews.llvm.org/D120684#3383749>, @philnik wrote:

> I'm not perfectly happy with some of the new names, but I'm OK with them. I also don't have any better ideas for them currently.

Yeah, that's the problem. `-Wshadow` creates the need to dance around quite a bit to get things to compile sometimes.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120684/new/

https://reviews.llvm.org/D120684