[libcxx-commits] [PATCH] D121632: [libc++] Switch to the new testing configurations by default

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/CMakeLists.txt:143
+  set(LIBCXX_DEFAULT_TEST_CONFIG "llvm-libc++-shared-gcc.cfg.in")
+elseif(WIN32 AND NOT MINGW)
+  if (LIBCXX_ENABLE_SHARED)
----------------
mstorsjo wrote:
> This is all a matter of taste, but I'd find `elseif(MINGW)  elseif(WIN32) #clang-cl elseif(...` more straightforward, instead of the `WIN32 AND NOT MINGW` followed by the complement of the negation.
> 
> Alternatively, depending on which one to single out, one could also use `elseif (MSVC) # clang-cl elseif (MINGW)`, as `MSVC` is defined in clang-cl configurations.
You're right, I'll improve this in the next rev.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121632/new/

https://reviews.llvm.org/D121632