[libcxx-commits] [PATCH] D121015: [libunwind] Add a _LIBUNWIND_VERSION macro

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D121015#3379587 <https://reviews.llvm.org/D121015#3379587>, @mgorny wrote:

> I'm sorry, my replacement PSU just arrived today and I'm slowly catching up with everything. I presume we don't need to worry about backwards compatibility, so LGTM.

No worries. If you think this works for your use case, then I think this should be good to go. I verified and we do take that code path when we build the runtimes with `LIBCXXABI_USE_LLVM_UNWINDER`.

However, upon thinking about it again, I think it's safer to add a temporary workaround to detect LLVM's libunwind in libc++abi for a couple of releases, until we can assume that libunwind headers from LLVM 15 (or newer) are being used to build libc++abi. That should take care of folks who might be building libc++abi against an out-of-sync LLVM libunwind (e.g. as part of a SDK or a system-provided libunwind). I'll add a workaround and you folks can tell me what you think -- sorry for the churn.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121015/new/

https://reviews.llvm.org/D121015