[libcxx-commits] [PATCH] D121604: [libc++][NFC] Remove several redundant #if _LIBCPP_STD_VER > 17 in <span>

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/include/span:255
     }
-#endif // _LIBCPP_STD_VER > 17 && !defined(_LIBCPP_HAS_NO_INCOMPLETE_RANGES)
+#endif
 
----------------
philnik wrote:
> Why have you removed the comment completely? (Also in line 437)
When blocks are really small, the readability improvement of commenting the `#endif` is questionable.

Do you agree @jloser @philnik ? If not, I don't mind adding them back.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121604/new/

https://reviews.llvm.org/D121604