[libcxx-commits] [PATCH] D120684: [libc++] Define _LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER whenever we enable warnings in the test suite

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/include/barrier:126-129
+    __barrier_base(ptrdiff_t __expected, _CompletionF __completion_func = _CompletionF())
             : __expected(__expected), __base(__construct_barrier_algorithm_base(this->__expected),
                                              &__destroy_barrier_algorithm_base),
+              __expected_adjustment(0), __completion(std::move(__completion_func)), __phase(0)
----------------
Is this a drive-by or does any compiler complain here?


================
Comment at: libcxx/utils/libcxx/test/params.py:25
   '-Wno-atomic-alignment',
+  '-Wno-shadow',
 
----------------
Why are you disabling `-Wshadow`? I'm pretty certain this will regress very fast.


================
Comment at: libcxx/utils/libcxx/test/params.py:43
   '-Wunreachable-code',
   '-Wno-unused-local-typedef',
 ]
----------------
This doesn't look like it should be here. Why do we disable this warning?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120684/new/

https://reviews.llvm.org/D120684