[libcxx-commits] [PATCH] D121552: [libc++] Add warning pragma macros in the test suite

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF added inline comments.


================
Comment at: libcxx/test/libcxx/utilities/tuple/tuple.tuple/tuple.cnstr/PR20855_tuple_ref_binding_diagnostics.fail.cpp:15
 
-#ifdef __clang__
-#pragma clang diagnostic ignored "-Wdangling-field"
----------------
EricWF wrote:
> I suspect this is needed, and the test just wasn't run with warnings enabled. Otherwise something is broken.
> That warning is specifically what the test is trying to generate. If it's not being generated, there's something very weird going on.
Nevermind. I tried it for myself. Don't know what's going on but this is fine to remove. 

Same thing with the other warnings I complained about. Sorry about that. I'm often dumb.


================
Comment at: libcxx/test/support/unique_ptr_test_helper.h:137
 
-#if defined(__GNUC__)
-#pragma GCC diagnostic push
----------------
EricWF wrote:
> I think this needs to stay.
Or it doesn't ignore me. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121552/new/

https://reviews.llvm.org/D121552