[libcxx-commits] [PATCH] D118926: [libc++] Adds TEST_IF_INT128.

Mon Mar 14 07:21:26 PDT 2022

ldionne added a comment.
Herald added a project: All.

In D118926#3308241 <https://reviews.llvm.org/D118926#3308241>, @Mordante wrote:

> I'll leave this open for the other use case.
> @ldionne which do you prefer for naming 1 or 2? When also 2 I'll make a separate patch to `s/_LIBCPP_IF_WIDE_CHARACTERS/_LIBCPP_IF_HAS_WIDE_CHARACTERS/`

I've looked at the places where this is used in D121514 <https://reviews.llvm.org/D121514> and my preference to use a simple `#if defined(...)` would remain, TBH. It's only used in two places in D121514 <https://reviews.llvm.org/D121514>, and the unusual look of the macro makes me scratch my head more than anything.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118926/new/

https://reviews.llvm.org/D118926