[libcxx-commits] [PATCH] D121552: [libc++] Add warning pragma macros in the test suite

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF added inline comments.


================
Comment at: libcxx/test/std/utilities/meta/meta.const.eval/is_constant_evaluated.pass.cpp:28
 // because it's explicitly testing those cases.
-#if TEST_HAS_WARNING("-Wconstant-evaluated") && defined(__clang__)
-#pragma clang diagnostic ignored "-Wconstant-evaluated"
-#endif
+TEST_CLANG_DIAGNOSTIC_IGNORED("-Wconstant-evaluated")
+TEST_MSVC_DIAGNOSTIC_IGNORED(5063)
----------------
What version was `-Wconstant-evaluated` added to Clang?


================
Comment at: libcxx/test/std/utilities/meta/meta.const.eval/is_constant_evaluated.pass.cpp:36
 {
-#ifdef __cpp_lib_is_constant_evaluated
-#ifdef TEST_COMPILER_MSVC
----------------
Where did this go? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121552/new/

https://reviews.llvm.org/D121552