[libcxx-commits] [PATCH] D121552: [libc++] Add warning pragma macros in the test suite

Sun Mar 13 15:47:13 PDT 2022

philnik added a comment.

In D121552#3378148 <https://reviews.llvm.org/D121552#3378148>, @EricWF wrote:

> Every single warning we disable should come with a comment explaining why the warning isn't real and why we're not fixing it some other way. We shouldn't encourage suppressing warnings.

I mostly agree, but I don't think this is the PR for that.

================
Comment at: libcxx/test/std/containers/sequences/array/array.tuple/tuple_element.fail.cpp:15
-#if defined(__clang__)
-#pragma clang diagnostic ignored "-Warray-bounds"
-#endif
----------------
EricWF wrote:
> What happened here?
What are you asking exactly? Why I removed it? Because it doesn't seem to suppress any warnings. Why was it there in the first place? I don't know.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121552/new/

https://reviews.llvm.org/D121552