[libcxx-commits] [PATCH] D121552: [libc++] Add warning pragma macros in the test suite

Eric Fiselier via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Mar 13 15:26:32 PDT 2022


EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.

Every single warning we disable should come with a comment explaining why the warning isn't real and why we're not fixing it some other way. We shouldn't encourage suppressing warnings.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121552/new/

https://reviews.llvm.org/D121552



More information about the libcxx-commits mailing list