[libcxx-commits] [PATCH] D121528: [libc++] Replace _LIBCPP_HAS_NO_CONCEPTS with _LIBCPP_STD_VER > 17. NFCI.

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

LGTM % nits! Regarding the result types, I change that in D121435 <https://reviews.llvm.org/D121435>.



================
Comment at: libcxx/include/__iterator/reverse_iterator.h:195
 }
 #endif
 
----------------
Could you add the comment here too?


================
Comment at: libcxx/include/__utility/cmp.h:104
 }
 #endif
 
----------------
Also here


================
Comment at: libcxx/include/string_view:738
   basic_string_view(_Range) -> basic_string_view<ranges::range_value_t<_Range>>;
 #endif
 
----------------
And here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121528/new/

https://reviews.llvm.org/D121528