[libcxx-commits] [PATCH] D121528: [libc++] Replace _LIBCPP_HAS_NO_CONCEPTS with _LIBCPP_STD_VER > 17. NFCI.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

Thanks a lot for working on this! Only some small requests and please fix the CI. Otherwise LGTM!



================
Comment at: libcxx/include/span:184
   is_convertible_v<remove_reference_t<ranges::range_reference_t<_Range>>(*)[], _ElementType(*)[]>;
 #endif
 
----------------
Pre-existing: Can you add a comment here?


================
Comment at: libcxx/include/string_view:325
     basic_string_view(_Range&& __r) : __data(ranges::data(__r)), __size(ranges::size(__r)) {}
 #endif
 
----------------
Pre-existing: Can you add a comment here?


================
Comment at: libcxx/test/std/containers/views/range_concept_conformance.compile.pass.cpp:11
-// UNSUPPORTED: libcpp-no-concepts
-// UNSUPPORTED: libcpp-has-no-incomplete-ranges
 
----------------
This test fails this should probably remain `// UNSUPPORTED: libcpp-has-no-incomplete-ranges`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121528/new/

https://reviews.llvm.org/D121528