[libcxx-commits] [PATCH] D121492: [libc++] Fix performance inconsistency between unordered_map copy-assignment and copy-construction

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Just curious can you share the before and after timings of this change?



================
Comment at: libcxx/include/unordered_set:601
     {
-        __table_ = __u.__table_;
+        if (this != _VSTD::addressof(__u)) {
+            __table_.clear();
----------------
Please update the description/title to mention `unordered_set` and the `multi` versions.



================
Comment at: libcxx/test/libcxx/containers/unord/perf.assignment_vs_construction.pass.cpp:10
+// This test ensures that copy assignment and copy construction are within a reasonable
+// margin from each other performance wise.
+
----------------
This raises the same questions as this test for D121485.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121492/new/

https://reviews.llvm.org/D121492