[libcxx-commits] [PATCH] D121248: [libc++][ranges] Implement ranges::find{, _if, _if_not}

[Konstantin Varlamov via Phabricator via libcxx-commits]

var-const accepted this revision.
var-const added a comment.

Thanks for addressing all the feedback! LGTM when the CI is green.



================
Comment at: libcxx/test/support/almost_satisfies_types.h:115
+
+// almost an sentinel_for cpp20_input_iterator
+class SentinelForNotWeaklyEqualityComparableWith {
----------------
Ultranit: `s/an/a` (here and above).


================
Comment at: libcxx/test/support/almost_satisfies_types.h:124
+
+using InputRangeNotSentinelEqualityComparableWith =
+  UncheckedRange<cpp20_input_iterator<int*>, SentinelForNotWeaklyEqualityComparableWith>;
----------------
Same note here: I'm not against having this type, but I also think that `InputRangeNotSentinelSemiregular` is sufficient.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121248/new/

https://reviews.llvm.org/D121248