[libcxx-commits] [PATCH] D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS

Zibi Sarbino via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 10 14:01:02 PST 2022


zibi marked an inline comment as done.
zibi added inline comments.


================
Comment at: libcxxabi/test/test_exception_storage.pass.cpp:19
 
 void *thread_code (void *parm) {
+  size_t* result = (size_t*)parm;
----------------
EricWF wrote:
> This diff is hard to read because of all the whitespace changes.
> What has actually changed here?
I decided to do clang-format on the entire file since CI was failing and suggesting indentation which was not inline with the rest of the file. The file is relatively small. The relevant changes are inside the main():


```
#ifdef _LIBCXXABI_HAS_NO_THREADS
  size_t thread_globals;
  thread_code(&thread_globals);
  // Check that __cxa_get_globals() is not NULL.
  return (thread_globals == 0) ? 1 : 0;
#else  // !_LIBCXXABI_HAS_NO_THREADS
  // If threads are disabled at runtime, revert to single-threaded test.
  if (!__libcpp_is_threading_api_enabled()) {
    thread_code((void*)thread_globals);
    // Check that __cxa_get_globals() is not NULL.
    return (thread_globals[0] == 0) ? 1 : 0;
  }
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120348/new/

https://reviews.llvm.org/D120348



More information about the libcxx-commits mailing list