[libcxx-commits] [PATCH] D120951: [libc++] Prepare string tests for constexpr

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 10 11:20:41 PST 2022


philnik marked 2 inline comments as done.
philnik added inline comments.


================
Comment at: libcxx/test/std/strings/basic.string/string.contains/contains.string_view.pass.cpp:93
 #if TEST_STD_VER > 17
   // static_assert(test());
 #endif
----------------
EricWF wrote:
> Please don't go adding commented out tests in the future. 
This was requested by Louis.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120951/new/

https://reviews.llvm.org/D120951



More information about the libcxx-commits mailing list