[libcxx-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

[Danny Mösch via Phabricator via libcxx-commits]

SimplyDanny added a comment.

I'm happy that you found a reasonable compromise. I like it too. ;)

Now, I ask you to help me a little bit with the workflow and the test failures. The review comments are all taken care of as far as I see. One reviewer approved the changes, others are still in a "needs changes"  or an undecided state. Are approvals of all reviewers required? I guess, the test failures have nothing to do with my changes, or have they? Can we just ignore them if they are unrelated?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121078/new/

https://reviews.llvm.org/D121078