[libcxx-commits] [PATCH] D121110: [libc++] Add tests for the content of <cstddef>

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/test/std/language.support/support.types/cstddef.compile.pass.cpp:33
+using MaxAlignT = std::max_align_t;
+using NullptrT = std::nullptr_t;
+#endif
----------------
Quuxplusone wrote:
> `std::nullptr_t` is also provided in C++03 mode, right? So this line (and maybe the other too) should go outside the `#if`, so they get tested in all modes.
> (The only compiler+library combo that's ever tested in C++03 mode is clang+libc++, which does provide `std::nullptr_t`, so there's no reason to guard it under an `#if`.)
> 
> Otherwise we have no coverage for std::nullptr_t-in-C++03-mode.
Hmm, right. I'd still rather move that test to the libc++ specific test, just for clarity. But yeah, good catch again. I guess I don't care enough about C++03!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121110/new/

https://reviews.llvm.org/D121110